Updating Server creation for localhost #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my last change, I missed this line of code. Adding the host parameter and removing the base_path param.
Build PASSEDStarted: 2018-01-26 01:07:55 View more information about this build on: |
|
Why does this have to be |
|
@jgraham : I should have included it in my initial PR. It's because of a feature missing in our webdriver. Same thing goes for IEDriver, which is why that one matches the Edge code. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/3901350/ |
|
@gsnedders and @jgraham Anything else to do here? I keep having to send this url to people who are trying to run these tests... :-) |
gsnedders
approved these changes
Feb 15, 2018
|
@thejohnjansen I was waiting for @jgraham given he has more of an idea about this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last change, I missed this line of code. Adding the host parameter and removing the base_path param.
This change is